fix: Substream only cameras should not be triggerable (#1848)

- Closes #1846

src/camera-manager/browse-media/camera.ts

@@ -25,7 +25,7 @@ export class BrowseMediaCamera extends Camera {
       throw new CameraInitializationError(localize('error.no_camera_entity'), config);
     }
     this._entity = entity;
-    return this;
+    return await super.initialize(options);
   }
 
   public getEntity(): Entity | null {

src/camera-manager/camera.ts

@@ -34,10 +34,12 @@ export class Camera {
   }
 
   async initialize(options: CameraInitializationOptions): Promise<Camera> {
-    options.stateWatcher.subscribe(
-      this._stateChangeHandler,
-      this._config.triggers.entities,
-    );
+    if (this._capabilities?.has('trigger')) {
+      options.stateWatcher.subscribe(
+        this._stateChangeHandler,
+        this._config.triggers.entities,
+      );
+    }
     this._onDestroy(() => options.stateWatcher.unsubscribe(this._stateChangeHandler));
     return this;
   }

src/camera-manager/frigate/camera.ts

@@ -49,7 +49,11 @@ export class FrigateCamera extends Camera {
   public async initialize(options: FrigateCameraInitializationOptions): Promise<Camera> {
     await this._initializeConfig(options.hass, options.entityRegistryManager);
     await this._initializeCapabilities(options.hass);
-    await this._subscribeToEvents(options.hass, options.frigateEventWatcher);
+
+    if (this._capabilities?.has('trigger')) {
+      await this._subscribeToEvents(options.hass, options.frigateEventWatcher);
+    }
+
     return await super.initialize(options);
   }
 
@@ -142,6 +146,7 @@ export class FrigateCamera extends Camera {
         live: true,
         menu: true,
         substream: true,
+        trigger: true,
         ...(combinedPTZCapabilities && { ptz: combinedPTZCapabilities }),
       },
       {

src/camera-manager/generic/engine-generic.ts

@@ -70,6 +70,7 @@ export class GenericCameraManagerEngine implements CameraManagerEngine {
           seek: false,
           snapshots: false,
           substream: true,
+          trigger: true,
           ptz: getPTZCapabilitiesFromCameraConfig(cameraConfig) ?? undefined,
         },
         {

src/camera-manager/motioneye/engine-motioneye.ts

@@ -90,6 +90,7 @@ export class MotionEyeCameraManagerEngine extends BrowseMediaCameraManagerEngine
           seek: false,
           snapshots: true,
           substream: true,
+          trigger: true,
           ptz: getPTZCapabilitiesFromCameraConfig(cameraConfig) ?? undefined,
         },
         {

src/camera-manager/reolink/engine-reolink.ts

@@ -144,6 +144,7 @@ export class ReolinkCameraManagerEngine extends BrowseMediaCameraManagerEngine {
           seek: false,
           snapshots: false,
           substream: true,
+          trigger: true,
           ptz: getPTZCapabilitiesFromCameraConfig(cameraConfig) ?? undefined,
         },
         {

src/types.ts

@@ -106,6 +106,8 @@ export interface CapabilitiesRaw {
   ptz?: PTZCapabilities;
 
   menu?: boolean;
+
+  trigger?: boolean;
 }
 
 export type CapabilityKey = keyof CapabilitiesRaw;
@@ -120,6 +122,7 @@ export const capabilityKeys: readonly [CapabilityKey, ...CapabilityKey[]] = [
   'seek',
   'snapshots',
   'substream',
+  'trigger',
 ] as const;
 
 export interface Icon {